[
https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155561#comment-16155561
]
ASF GitHub Bot commented on FLINK-7068:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4358#discussion_r137293376
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -215,10 +215,10 @@ public static ClassLoader retrieveClassLoader(
JobManagerMessages.ClassloadingProps props =
optProps.get();
InetSocketAddress serverAddress = new
InetSocketAddress(jobManager.getHostname(), props.blobManagerPort());
- final BlobCache blobClient;
+ final PermanentBlobCache blobClient;
try {
- // TODO: Fix lifecycle of BlobCache to properly
close it upon usage
- blobClient = new BlobCache(serverAddress,
config, highAvailabilityServices.createBlobStore());
+ // TODO: Fix lifecycle of PermanentBlobCache to
properly close it upon usage
+ blobClient = new
PermanentBlobCache(serverAddress, config,
highAvailabilityServices.createBlobStore());
--- End diff --
shouldn't the variable be called `permanentBlobCache` instead of
`blobClient`?
> change BlobService sub-classes for permanent and transient BLOBs
> ----------------------------------------------------------------
>
> Key: FLINK-7068
> URL: https://issues.apache.org/jira/browse/FLINK-7068
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> A {{PermanentBlobStore}} should resemble use cases for BLOBs that are
> permanently stored for a job's life time (HA and non-HA).
> A {{TransientBlobStore}} should reflect BLOB offloading for logs, RPC, etc.
> which even does not have to be reflected by files.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
