[ 
https://issues.apache.org/jira/browse/FLINK-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156625#comment-16156625
 ] 

ASF GitHub Bot commented on FLINK-7598:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4653
  
    +1


> ineffective shaded artifacts checks in travis_mvn_watchdog.sh
> -------------------------------------------------------------
>
>                 Key: FLINK-7598
>                 URL: https://issues.apache.org/jira/browse/FLINK-7598
>             Project: Flink
>          Issue Type: Bug
>          Components: Travis
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> The {{check_shaded_artifacts()}} checks have some shortcomings which render 
> them (partially) ineffective:
> * netty checks use {{wc -1}} but should use {{wc -l}}
> * (all) of these checks do not fail if the executed command fails (as can be 
> seen from the netty checks that pass without the line counting being correct)
> In the travis logs, this shows up as
> {code}
> ./tools/travis_mvn_watchdog.sh: line 382: 10052 Terminated              
> watchdog
> wc: invalid option -- '1'
> Try 'wc --help' for more information.
> ./tools/travis_mvn_watchdog.sh: line 297: [: !=: unary operator expected
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to