[ 
https://issues.apache.org/jira/browse/FLINK-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167214#comment-16167214
 ] 

ASF GitHub Bot commented on FLINK-4047:
---------------------------------------

Github user zhangminglei commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4659#discussion_r139048412
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/java/functions/KeySelector.java 
---
    @@ -36,7 +37,7 @@
     public interface KeySelector<IN, KEY> extends Function, Serializable {
     
        /**
    -    * User-defined function that extracts the key from an arbitrary object.
    +    * User-defined function that extracts the key from an deterministic 
object.
    --- End diff --
    
    Okay. Thanks. I will correct it soon.


> Fix documentation about determinism of KeySelectors
> ---------------------------------------------------
>
>                 Key: FLINK-4047
>                 URL: https://issues.apache.org/jira/browse/FLINK-4047
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.1.0, 1.0.3
>            Reporter: Fabian Hueske
>            Priority: Blocker
>              Labels: starter
>             Fix For: 1.4.0
>
>
> KeySelectors must return deterministic keys, i.e., if invoked multiple times 
> on the same object, the returned key must be the same.
> The documentation about this aspect is broken ("The key can be of any type 
> and be derived from arbitrary computations.").
> We need to fix the JavaDocs of the {{KeySelector}} interface and the web 
> documentation 
> (https://ci.apache.org/projects/flink/flink-docs-master/apis/common/index.html#specifying-keys).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to