[
https://issues.apache.org/jira/browse/FLINK-7410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168072#comment-16168072
]
ASF GitHub Bot commented on FLINK-7410:
---------------------------------------
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4624#discussion_r139187009
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UserDefinedFunction.scala
---
@@ -41,7 +41,7 @@ abstract class UserDefinedFunction extends Serializable {
def close(): Unit = {}
/**
- * @return true iff a call to this function is guaranteed to always
return
+ * @return true if a call to this function is guaranteed to always
return
--- End diff --
We should be writing out "if and only if" iff that is the intent.
> Use toString method to display operator names for UserDefinedFunction
> ---------------------------------------------------------------------
>
> Key: FLINK-7410
> URL: https://issues.apache.org/jira/browse/FLINK-7410
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Hequn Cheng
> Assignee: Hequn Cheng
>
> *Motivation*
> Operator names setted in table-api are used by visualization and logging, it
> is import to make these names simple and readable. Currently,
> UserDefinedFunction’s name contains class CanonicalName and md5 value making
> the name too long and unfriendly to users.
> As shown in the following example,
> {quote}
> select: (a, b, c,
> org$apache$flink$table$expressions$utils$RichFunc1$281f7e61ec5d8da894f5783e2e17a4f5(a)
> AS _c3,
> org$apache$flink$table$expressions$utils$RichFunc2$fb99077e565685ebc5f48b27edc14d98(c)
> AS _c4)
> {quote}
> *Changes:*
>
> Use {{toString}} method to display operator names for UserDefinedFunction.
> The method will return class name by default. Users can also override the
> method to return whatever he wants.
> What do you think [~fhueske] ?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
