[
https://issues.apache.org/jira/browse/FLINK-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169980#comment-16169980
]
ASF GitHub Bot commented on FLINK-7534:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4603#discussion_r139413912
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/messages/webmonitor/StatusOverviewWithVersion.java
---
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.messages.webmonitor;
+
+import org.apache.flink.runtime.rest.messages.ResponseBody;
+import org.apache.flink.util.Preconditions;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+
+/**
+ * Status overview message including the current flink version and commit
id.
+ */
+public class StatusOverviewWithVersion extends StatusOverview implements
ResponseBody {
--- End diff --
I suggest to add a test to verify that a given Request-/ResponseBody can be
mapped to JSON and back again. An example can be found here:
https://github.com/zentol/flink/blob/7072/flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/JobSubmitRequestBodyResponseTest.java
(We can probably create a simple test base for this)
> Create LegacyRestHandlerAdapter for the old REST handlers
> ---------------------------------------------------------
>
> Key: FLINK-7534
> URL: https://issues.apache.org/jira/browse/FLINK-7534
> Project: Flink
> Issue Type: Sub-task
> Components: REST, Webfrontend
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> Create a {{LegacyRestHandlerAdapter}} to integrate the old REST handler with
> the new {{RestServerEndpoint}} and the {{AbstractRestHandler}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
