Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r139591493
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/RowTimeBoundedStreamInnerJoin.scala
---
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.join
+
+import org.apache.flink.api.common.typeinfo.TypeInformation
+import org.apache.flink.streaming.api.functions.co.CoProcessFunction
+import org.apache.flink.table.runtime.types.CRow
+import org.apache.flink.types.Row
+
+/**
+ * The function to execute row(event) time bounded stream inner-join.
+ */
+class RowTimeBoundedStreamInnerJoin(
+ leftLowerBound: Long,
+ leftUpperBound: Long,
+ allowedLateness: Long,
+ leftType: TypeInformation[Row],
+ rightType: TypeInformation[Row],
+ genJoinFuncName: String,
+ genJoinFuncCode: String,
+ leftTimeIdx: Int,
+ rightTimeIdx: Int)
+ extends TimeBoundedStreamInnerJoin(
+ leftLowerBound,
+ leftUpperBound,
+ allowedLateness,
+ leftType,
+ rightType,
+ genJoinFuncName,
+ genJoinFuncCode,
+ leftTimeIdx,
+ rightTimeIdx,
+ JoinTimeIndicator.ROWTIME) {
+
+ override def checkRowOutOfDate(timeForRow: Long, watermark: Long) = {
+ timeForRow <= watermark - allowedLateness
+ }
+
+ override def updateOperatorTime(ctx: CoProcessFunction[CRow, CRow,
CRow]#Context): Unit = {
+ rightOperatorTime =
+ if (ctx.timerService().currentWatermark() > 0)
ctx.timerService().currentWatermark()
--- End diff --
Yes, you are right. I'll move this check to places where we actually use
the watermark.
---
