[
https://issues.apache.org/jira/browse/FLINK-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584572#comment-14584572
]
ASF GitHub Bot commented on FLINK-2203:
---------------------------------------
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/831#issuecomment-111701489
The changes look good except for comments I had about the loops.
For the tests, did you try doing it as in TraversableSerializerTest.scala.
Here, we override deepEquals() and the runTests() method can be modified to
take the RowTypeInfo that was explicitly created. The reason why I would like
it to derive from the SerializerTestBase as all the other serializers is that
we have to change the tests for RowSerializer if we adapt the tests there. And
this would likely be forgotten by future contributors.
> Add Support for Null-Values in RowSerializer
> --------------------------------------------
>
> Key: FLINK-2203
> URL: https://issues.apache.org/jira/browse/FLINK-2203
> Project: Flink
> Issue Type: Improvement
> Components: Table API
> Reporter: Aljoscha Krettek
> Assignee: Shiti Saxena
> Priority: Minor
> Labels: Starter
>
> This would be a start towards proper handling of null values. We would still
> need to add support for null values in aggregations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
