Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4358#discussion_r139957010
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
@@ -174,7 +176,6 @@ public ServerSocket createSocket(int port) throws
IOException {
// start the server thread
setName("BLOB Server listener at " + getPort());
setDaemon(true);
- start();
--- End diff --
Basically yes but this pattern does not work well with classes inheriting
from `BlobServer`. Here, this is only the case for the
`TestingFailingBlobServer` which sets additional properties and relies on them
being set while executing `run()`. If started in the constructor, the `run()`
method would work on a partially initialised object.
---
