[
https://issues.apache.org/jira/browse/FLINK-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173652#comment-16173652
]
ASF GitHub Bot commented on FLINK-7486:
---------------------------------------
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/4628#discussion_r140021958
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
---
@@ -366,6 +425,34 @@ public String call(String s) {
}
/**
+ * Internal class that stores the parsed information about soft
constraint
+ * It encapsulates fields:
+ * 1. Host attribute name
+ * 2. Expected number of unique values for given host attribute
+ * 3. A callback coTaskGetter used while evaluating balancing
constraint
+ */
+ static class BalancedHostAttrConstraintParams {
--- End diff --
Please let us make this configuration class immutable. Mark the
`hostAttr` and `numOfExpectedUniqueValues` fields as final. Move
`coTasksGetter` elsewhere.
> flink-mesos: Support for adding unique attribute / group_by attribute
> constraints
> ---------------------------------------------------------------------------------
>
> Key: FLINK-7486
> URL: https://issues.apache.org/jira/browse/FLINK-7486
> Project: Flink
> Issue Type: Improvement
> Components: Mesos
> Affects Versions: 1.3.2
> Reporter: Bhumika Bayani
> Assignee: Bhumika Bayani
>
> In our setup, we have multiple mesos-workers. Inspite of this, flink
> application master most of the times ends up spawning all task-managers on
> same mesos-worker.
> We intend to ensure HA of task managers. We would like to make sure each
> task-manager is running on different mesos-worker as well as such
> mesos-worker which does not share the AZ attribute with earlier task manager
> instances.
> Netflix-fenzo supports adding UniqueHostAttribute and BalancedHostAttribute
> contraints. Flink-mesos should also enable us to add these kind of
> constraints.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
