Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4485#discussion_r140190096
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPoolTest.java
---
@@ -264,11 +271,13 @@ public void
testRequestMemorySegmentsWithBuffersTaken() throws IOException, Inte
assertNotNull(buffer);
}
- // if requestMemorySegments() blocks, this will make
sure that enough buffers are freed
- // eventually for it to continue
+ // requestMemorySegments() below will and wait for
buffers
--- End diff --
typo from my code example: should be "below will wait for buffers"
---