[
https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174637#comment-16174637
]
ASF GitHub Bot commented on FLINK-7650:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4697
[FLINK-7650] [flip6] Port JobCancellationHandler to new REST endpoint
## What is the purpose of the change
Let the `JobCancellationHandler` implement the `LegacyRestHandler`
interface. Moreover,
this commit adds the `DELETE` method to `HttpMethodWrapper` and the
`RestServerEndpoint#registerHandler` method. This PR also adds the
`DispatcherGateway#cancelJob` and `JobMasterGateway#cancel` RPC calls.
## Brief change log
- Add `DispatcherGateway#cancelJob` and `JobMasterGateway#cancel` RPC calls
- Let `JobCancellationHandler` implement `LegacyRestHandler`
- Introduce `JobMessageParameters`
- Introduce `JobCancellationHeaders`
- Add `JobCancellationHandler` to `DispatcherRestEndpoint`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink portJobCancellationHandler
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4697.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4697
----
commit f20cd411752b75924a8ca65b981144aeb2fc9c1b
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2017-09-21T08:53:24Z
[FLINK-7650] [flip6] Port JobCancellationHandler to new REST endpoint
Let the JobCancellationHandler implement the LegacyRestHandler interface.
Moreover,
this commit adds the DELETE method to HttpMethodWrapper and the
RestServerEndpoint#registerHandler method.
----
> Port JobCancellationHandler to new REST endpoint
> ------------------------------------------------
>
> Key: FLINK-7650
> URL: https://issues.apache.org/jira/browse/FLINK-7650
> Project: Flink
> Issue Type: Sub-task
> Components: REST, Webfrontend
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.4.0
>
>
> Port existing {{JobCancellationHandler}} to new REST endpoint
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
