[
https://issues.apache.org/jira/browse/FLINK-7661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174841#comment-16174841
]
ASF GitHub Bot commented on FLINK-7661:
---------------------------------------
GitHub user zhijiangW opened a pull request:
https://github.com/apache/flink/pull/4698
[FLINK-7661][network] Add credit field in PartitionRequest message
## What is the purpose of the change
*`PartitionRequest` message adds the credit field which corresponds to the
number of exclusive segments in `InputChannel`*.
*This pull request is based on
[4499](https://github.com/apache/flink/pull/4499) whose commit is also included
for passing travis. Review the third commit for this PR change*.
## Brief change log
- *Add credit field in `PartitionRequest` message*
- *Add `getInitialCredit()` method in `RemoteInputChannel`*
## Verifying this change
This change is already covered by existing tests, such as
*NettyMessageSerializationTest*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhijiangW/flink FLINK-7661
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4698.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4698
----
commit 693303c5d720fd720865f60aaf9a59f4bf547396
Author: Zhijiang <[email protected]>
Date: 2017-08-07T09:31:17Z
[FLINK-7378][core]Create a fix size (non rebalancing) buffer pool type for
the floating buffers
commit 4c582cba58dbdfb0485b3d23375a62428a160b2b
Author: Zhijiang <[email protected]>
Date: 2017-08-14T06:30:47Z
[FLINK-7394][core] Manage exclusive buffers in RemoteInputChannel
commit b9e0447202a7621adf8bd8646e7d2a54dca00f2d
Author: Zhijiang <[email protected]>
Date: 2017-09-21T08:28:16Z
[FLINK-7661][network] Add credit field in PartitionRequest message
----
> Add credit field in PartitionRequest message
> --------------------------------------------
>
> Key: FLINK-7661
> URL: https://issues.apache.org/jira/browse/FLINK-7661
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.4.0
> Reporter: zhijiang
> Assignee: zhijiang
>
> Currently the {{PartitionRequest}} message contains {{ResultPartitionID}} |
> {{queueIndex}} | {{InputChannelID}} fields.
> We will add a new {{credit}} field indicating the initial credit of
> {{InputChannel}}, and this info can be got from {{InputChannel}} directly
> after assigning exclusive buffers to it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
