[
https://issues.apache.org/jira/browse/FLINK-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175640#comment-16175640
]
ASF GitHub Bot commented on FLINK-7647:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4691#discussion_r140379775
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java
---
@@ -55,16 +59,19 @@
public class DispatcherRestEndpoint extends RestServerEndpoint {
private final GatewayRetriever<DispatcherGateway> leaderRetriever;
+ private final Configuration clusterConfiguration;
private final RestHandlerConfiguration restConfiguration;
private final Executor executor;
public DispatcherRestEndpoint(
- RestServerEndpointConfiguration configuration,
+ Configuration clusterConfiguration,
+ RestServerEndpointConfiguration endpointConfiguration,
--- End diff --
Shall we remove the order between `clusterConfiguration` and
`endpointConfiguration`? I usually like to have the super class arguments first.
> Port JobManagerConfigHandler to new REST endpoint
> -------------------------------------------------
>
> Key: FLINK-7647
> URL: https://issues.apache.org/jira/browse/FLINK-7647
> Project: Flink
> Issue Type: Sub-task
> Components: REST, Webfrontend
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Labels: flip-6
> Fix For: 1.4.0
>
>
> Port existing {{JobManagerConfigHandler}} to new REST endpoint
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
