Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4671#discussion_r140458205
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/async/AbstractAsyncCallableWithResources.java
 ---
    @@ -0,0 +1,194 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.io.async;
    +
    +import org.apache.flink.util.ExceptionUtils;
    +
    +import java.io.IOException;
    +
    +/**
    + * The abstract class encapsulates the lifecycle and execution strategy 
for asynchronous operations that use resources.
    + *
    + * @param <V> return type of the asynchronous call.
    + */
    +public abstract class AbstractAsyncCallableWithResources<V> implements 
StoppableCallbackCallable<V> {
    +
    +   /** Tracks if the stop method was called on this object. */
    +   private volatile boolean stopped;
    +
    +   /** Tracks if call method was executed (only before stop calls). */
    +   private volatile boolean called;
    +
    +   /** Stores a collected exception if there was on during stop. */
    --- End diff --
    
    nit: "if there was one ..."


---

Reply via email to