[GitHub] flink pull request #4665: [Flink-7611]add metrics to measure the num of data...

[bowenli86]

Github user bowenli86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4665#discussion_r140645413
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
 ---
    @@ -231,6 +231,8 @@ public void merge(W mergeResult,
                // windowAssigner is event time and current timestamp + allowed 
lateness no less than element timestamp
                if (isSkippedElement && lateDataOutputTag != null && 
isElementLate(element)) {
    --- End diff --
    
    I see. Data being side outputted isn't considered being dropped. 
    
    LGTM


---