[ 
https://issues.apache.org/jira/browse/FLINK-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178304#comment-16178304
 ] 

ASF GitHub Bot commented on FLINK-3829:
---------------------------------------

GitHub user yew1eb opened a pull request:

    https://github.com/apache/flink/pull/4719

    [FLINK-3829][build] POM Cleanup flink-java

    ## What is the purpose of the change
    This PR changes the flink-java pom to
    
    - not contain unused dependencies
    - contain all used dependencies
    
    ## Brief change log
    ## Verifying this change
    _mvn dependency:analyze_
    
    ```
    [INFO] --- maven-dependency-plugin:2.10:analyze (default-cli) @ flink-java 
---
    [WARNING] Used undeclared dependencies found:
    [WARNING]    org.apache.flink:flink-metrics-core:jar:1.4-SNAPSHOT:compile
    [WARNING]    com.esotericsoftware.kryo:kryo:jar:2.24.0:compile
    [WARNING]    org.apache.flink:flink-annotations:jar:1.4-SNAPSHOT:compile
    [WARNING]    commons-cli:commons-cli:jar:1.3.1:compile
    [WARNING]    org.hamcrest:hamcrest-core:jar:1.3:test
    [WARNING] Unused declared dependencies found:
    [WARNING]    org.hamcrest:hamcrest-all:jar:1.3:test
    [WARNING]    org.apache.flink:force-shading:jar:1.4-SNAPSHOT:compile
    [WARNING]    org.powermock:powermock-module-junit4:jar:1.6.5:test
    [WARNING]    com.google.code.findbugs:jsr305:jar:1.3.9:compile
    [WARNING]    log4j:log4j:jar:1.2.17:test
    [WARNING]    org.powermock:powermock-api-mockito:jar:1.6.5:test
    [WARNING]    org.slf4j:slf4j-log4j12:jar:1.7.7:test
    ```
    
    After the change:
    
    ```
    [INFO] --- maven-dependency-plugin:2.10:analyze (default-cli) @ flink-java 
---
    [WARNING] Used undeclared dependencies found:
    [WARNING]    org.hamcrest:hamcrest-core:jar:1.3:test
    [WARNING] Unused declared dependencies found:
    [WARNING]    org.hamcrest:hamcrest-all:jar:1.3:test
    [WARNING]    org.apache.flink:force-shading:jar:1.4-SNAPSHOT:compile
    [WARNING]    org.powermock:powermock-module-junit4:jar:1.6.5:test
    [WARNING]    com.google.code.findbugs:jsr305:jar:1.3.9:compile
    [WARNING]    log4j:log4j:jar:1.2.17:test
    [WARNING]    org.powermock:powermock-api-mockito:jar:1.6.5:test
    [WARNING]    org.slf4j:slf4j-log4j12:jar:1.7.7:test
    ```
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes)
    
    ## Documentation
    none

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yew1eb/flink FLINK-3829

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4719.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4719
    
----
commit 54f09e83b040ffe80176b856052ccd7f1eaff969
Author: yew1eb <yew...@gmail.com>
Date:   2017-09-24T18:13:43Z

    POM Cleanup flink-java

----


> flink-java
> ----------
>
>                 Key: FLINK-3829
>                 URL: https://issues.apache.org/jira/browse/FLINK-3829
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Build System
>            Reporter: Till Rohrmann
>
> {noformat}
> [WARNING] Used undeclared dependencies found:
> [WARNING]    com.esotericsoftware.kryo:kryo:jar:2.24.0:compile
> [WARNING]    commons-cli:commons-cli:jar:1.3.1:compile
> [WARNING]    org.apache.flink:flink-metrics-core:jar:1.4-SNAPSHOT:compile
> [WARNING]    org.hamcrest:hamcrest-core:jar:1.3:test
> [WARNING]    org.apache.flink:flink-annotations:jar:1.4-SNAPSHOT:compile
> [WARNING] Unused declared dependencies found:
> [WARNING]    org.hamcrest:hamcrest-all:jar:1.3:test
> [WARNING]    org.powermock:powermock-module-junit4:jar:1.6.5:test
> [WARNING]    com.google.code.findbugs:jsr305:jar:1.3.9:compile
> [WARNING]    log4j:log4j:jar:1.2.17:test
> [WARNING]    org.powermock:powermock-api-mockito:jar:1.6.5:test
> [WARNING]    org.apache.flink:force-shading:jar:1.4-SNAPSHOT:compile
> [WARNING]    org.slf4j:slf4j-log4j12:jar:1.7.7:test
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to