[
https://issues.apache.org/jira/browse/FLINK-7393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178735#comment-16178735
]
ASF GitHub Bot commented on FLINK-7393:
---------------------------------------
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4708
Thanks @bowenli86.
Looks like a only a migration of unit tests, correct? LGTM, will merge this.
> Move unit tests of KinesisConfigUtil from FlinkKinesisConsumerTest to
> KinesisConfigUtilTest
> -------------------------------------------------------------------------------------------
>
> Key: FLINK-7393
> URL: https://issues.apache.org/jira/browse/FLINK-7393
> Project: Flink
> Issue Type: Test
> Components: Kinesis Connector
> Affects Versions: 1.3.2
> Reporter: Bowen Li
> Assignee: Bowen Li
> Priority: Minor
> Fix For: 1.4.0
>
>
> Right now,
> [{{FlinkKinesisConsumerTest}}|https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java]
> has lots of tests that actually should belong to {{KinesisConfigUtil}}, e.g.
> all the {{validateXxxConfiguration()}}
> We need to move those tests out to a new file {{KinesisConfigUtilTest}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
