Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4722#discussion_r141034332
  
    --- Diff: 
flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java
 ---
    @@ -442,6 +444,32 @@ public void testDisposeDeletesAllDirectories() throws 
Exception {
        }
     
        @Test
    +   public void testGetKeys() throws Exception {
    --- End diff --
    
    This test should go into `StateBackendTestBase`. This way, you don't have 
to repeat it for the Rocks and the Heap backend.


---

Reply via email to