Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4729#discussion_r141294374
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -228,7 +234,14 @@ public void startNewWorker(ResourceProfile
resourceProfile) {
@Override
public void stopWorker(ResourceID resourceID) {
--- End diff --
I actually think that we should refactor this method to take a parameter of
generic type `WorkerType` which contains all the framework specific
registration information. In the current `YarnResourceManager` implementation
case, it would be `ResourceID` which is generated from the container id. Thus,
we should be able to retrieve the `containerId` from it.
---
