[
https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182654#comment-16182654
]
ASF GitHub Bot commented on FLINK-7668:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4728#discussion_r141348426
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/JobConfigHandler.java
---
@@ -42,7 +42,7 @@
private static final String JOB_CONFIG_REST_PATH =
"/jobs/:jobid/config";
- public JobConfigHandler(ExecutionGraphHolder executionGraphHolder,
Executor executor) {
+ public JobConfigHandler(ExecutionGraphCache executionGraphHolder,
Executor executor) {
--- End diff --
nit: would be nice to update the variable name also to be consistent:
`executionGraphHolder` -> `executionGraphCache`
> Add AccessExecutionGraph refresh interval to ExecutionGraphHolder
> -----------------------------------------------------------------
>
> Key: FLINK-7668
> URL: https://issues.apache.org/jira/browse/FLINK-7668
> Project: Flink
> Issue Type: Sub-task
> Components: REST
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> Once we support offline {{AccessExecutionGraph}} implementation (see
> FLINK-7667) we should add a refresh interval to the {{ExecutionGraphHolder}}
> after which the {{AccessExecutionGraph}} is retrieved again from the
> {{JobMaster}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
