[ 
https://issues.apache.org/jira/browse/FLINK-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182698#comment-16182698
 ] 

ASF GitHub Bot commented on FLINK-7411:
---------------------------------------

Github user NicoK commented on the issue:

    https://github.com/apache/flink/pull/4517
  
    how about now?


> minor performance improvements in NettyMessage
> ----------------------------------------------
>
>                 Key: FLINK-7411
>                 URL: https://issues.apache.org/jira/browse/FLINK-7411
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Minor
>
> {{NettyMessage}} may be improved slightly performance-wise in these regards:
> - in {{NettyMessage.NettyMessageDecoder#decode()}}: instead of having 
> multiple if-elseif-... use a switch to cycle through the message ID
> - use a static {{NettyMessage}} subtype {{readFrom(ByteBuf buffer)}} - we do 
> not really need to have a virtual function here



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to