GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/4736
[FLINK-7371] [table] Add support for constant parameters in OVER aggregate
## What is the purpose of the change
This PR allows to pass constants to OVER window aggregates. E.g.
`.select('c, weightAvgFun('a, 42, 'b, "2") over 'w as 'wAvg)`.
## Brief change log
Until now the constants where simply ignored. I added code generation for
the literals in `AggregationCodeGenerator`.
## Verifying this change
I add a ITCase for it. I might add more tests if I have time. In general,
we need to rework the logic there a little bit, because I think we also do not
support DATE, TIME etc. right now.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-7371
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4736.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4736
----
commit 19e056e038009e22e2b607b38931f575d5c948df
Author: twalthr <[email protected]>
Date: 2017-09-27T15:11:28Z
[FLINK-7371] [table] Add support for constant parameters in OVER aggregate
----
---
