[
https://issues.apache.org/jira/browse/FLINK-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182812#comment-16182812
]
ASF GitHub Bot commented on FLINK-7699:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4735#discussion_r141388702
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolTest.java
---
@@ -211,10 +210,15 @@ public void testSetLessThanRequiredNumBuffers()
throws IOException {
@Test
public void testPendingRequestWithListenerAfterRecycle() throws
Exception {
- EventListener<Buffer> listener = spy(new
EventListener<Buffer>() {
+ BufferListener listener = spy(new BufferListener() {
@Override
- public void onEvent(Buffer buffer) {
+ public boolean notifyBufferAvailable(Buffer buffer) {
buffer.recycle();
+ return false;
--- End diff --
can you also add a test which verifies that requests for multiple buffers,
i.e. returning `true` here, works?
> Define the BufferListener interface to replace EventlListener in
> BufferProvider
> -------------------------------------------------------------------------------
>
> Key: FLINK-7699
> URL: https://issues.apache.org/jira/browse/FLINK-7699
> Project: Flink
> Issue Type: Sub-task
> Components: Core
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.4.0
>
>
> Currently the {{EventListener}} is used in {{BufferProvider}} to be notified
> of buffer available or destroyed pool.
> To be semantic clearly, we define a new {{BufferListener}} interface which
> can opt for a one-time only notification or to be notified repeatedly. And we
> can also notify the pool destroyed via explicitly method
> {{notifyBufferDestroyed}}.
> The {{RemoteInputChannel}} will implement the {{BufferListener}} interface to
> wait for floating buffers from {{BufferProvider}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
