[GitHub] flink pull request #4683: [FLINK-5944] Support reading of Snappy files

[mlipkovich]

Github user mlipkovich commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4683#discussion_r141424281
  
    --- Diff: flink-core/pom.xml ---
    @@ -52,6 +52,12 @@ under the License.
                        <artifactId>flink-shaded-asm</artifactId>
                </dependency>
     
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   <artifactId>flink-shaded-hadoop2</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    --- End diff --
    
    Thanks for your comment Aljoscha,
    So there are at least three ways on how to achieve it: either mark this 
dependency as 'provided', move Hadoop Snappy Codec related classes to 
flink-java module or move it to some separate module as suggested @haohui, but 
I'm not sure what should be inside this module


---