[
https://issues.apache.org/jira/browse/FLINK-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183414#comment-16183414
]
ASF GitHub Bot commented on FLINK-7724:
---------------------------------------
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/4739
[FLINK-7724][REST][Tests][Metrics] add extra metrics to
MetricStoreTest.setupStore
## What is the purpose of the change
This is a pre-requisite for FLINK-7694
I'm porting `JobMetricsHandler` to new REST endpoint. Part of the migration
is to make sure the json generated before and after stay the same for UI to
consume, and `JobMetricsHandler` is using `MetricStoreTest.setupStore()` to get
a mocked `MetricStore`.
Here comes the problem. Currently, `MetricStoreTest.setupStore()` mocks all
jobs with only one metric. We need to have at least one or two jobs with
multiple metrics to make the mocked `MetricStore` can cover most use cases, and
ensure the Json blob generated in `JobMetricsHandler` stay the same before and
after migration.
## Brief change log
- make two jobs in `MetricStoreTest.setupStore()` contain multiple metrics
## Verifying this change
This change is already covered by existing tests
## Does this pull request potentially affect one of the following parts:
none
## Documentation
none
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bowenli86/flink FLINK-7724
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4739.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4739
----
commit bc4aa8c3d9b057a6d35b620eb8e00048137e9361
Author: Bowen Li <[email protected]>
Date: 2017-09-27T22:30:02Z
[FLINK-7724] add extra metrics to MetricStoreTest.setupStore
commit d223444eba17c620e8c45c372a7b2e6fafdfd169
Author: Bowen Li <[email protected]>
Date: 2017-09-27T22:39:17Z
delete unrelated files
----
> add extra metrics to MetricStoreTest.setupStore
> -----------------------------------------------
>
> Key: FLINK-7724
> URL: https://issues.apache.org/jira/browse/FLINK-7724
> Project: Flink
> Issue Type: Test
> Components: REST, Tests
> Affects Versions: 1.4.0
> Reporter: Bowen Li
> Assignee: Bowen Li
> Fix For: 1.4.0
>
>
> Currently, {{MetricStoreTest.setupStore()}} only mock jobs with only one
> metrics. We need to have at least one job with multiple metrics to make the
> mocked MetricStore more generic.
> This is a pre-requisite for FLINK-7694
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
