[
https://issues.apache.org/jira/browse/FLINK-7745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187827#comment-16187827
]
ASF GitHub Bot commented on FLINK-7745:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4758
[FLINK-7745][tests] add tests for ensuring NetworkBufferPool
overprovisioning behaviour
## What is the purpose of the change
Currently, there are no unit tests verifying `NetworkBufferPool`'s
behaviour in the case that the available number of buffers is too small for it
to create LocalBufferPool instances. This PR adds some.
## Brief change log
- add unit tests for `NetworkBufferPool` not having as many buffers as
required
## Verifying this change
This change only adds unit tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-7745
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4758.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4758
----
commit 358a85f7b22d9e1f921cc5dc680c281a815c30be
Author: Nico Kruber <[email protected]>
Date: 2017-08-29T14:09:30Z
[FLINK-7745][tests] add tests for ensuring NetworkBufferPool
overprovisioning behaviour
----
> add tests for ensuring NetworkBufferPool overprovisioning behaviour
> -------------------------------------------------------------------
>
> Key: FLINK-7745
> URL: https://issues.apache.org/jira/browse/FLINK-7745
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> Currently, there are no unit tests verifying {{NetworkBufferPool}}'s
> behaviour in the case that the available number of buffers is too small for
> it to create {{LocalBufferPool}} instances. We should add some.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
