[
https://issues.apache.org/jira/browse/FLINK-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187843#comment-16187843
]
ASF GitHub Bot commented on FLINK-7746:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4759
[FLINK-7746][network] move ResultPartitionWriter#writeBufferToAllChannels
implementation up into ResultPartition
## What is the purpose of the change
As a step towards removing the (unneeded) `ResultPartitionWriter` wrapper,
we should move `ResultPartitionWriter#writeBufferToAllChannels` into
`ResultPartition` where single-channel writing happens anyway.
## Brief change log
- move the implementation of
`ResultPartitionWriter#writeBufferToAllChannels` into `ResultPartition` (keep a
delegating method for now - until `ResultPartitionWriter` is removed)
## Verifying this change
This change is a trivial rework / code cleanup without any (new) test
coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (yes)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-7746
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4759.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4759
----
commit d0cf483e0fb21010ed996935ffb14d62b34ee8ed
Author: Nico Kruber <[email protected]>
Date: 2017-08-29T15:32:52Z
[FLINK-7746][network] move ResultPartitionWriter#writeBufferToAllChannels
implementation up into ResultPartition
----
> move ResultPartitionWriter#writeBufferToAllChannels up into ResultPartition
> ---------------------------------------------------------------------------
>
> Key: FLINK-7746
> URL: https://issues.apache.org/jira/browse/FLINK-7746
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> As a step towards removing the (unneeded) {{ResultPartitionWriter}} wrapper,
> we should move {{ResultPartitionWriter#writeBufferToAllChannels}} into
> {{ResultPartition}} where single-channel writing happens anyway.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
