Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4742#discussion_r142121354
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobSubmitRequestBody.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.messages.job;
+
+import org.apache.flink.runtime.jobgraph.JobGraph;
+import org.apache.flink.runtime.rest.messages.RequestBody;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.io.ObjectOutputStream;
+import java.util.Arrays;
+
+/**
+ * Request for submitting a job.
+ *
+ * <p>We currently require the job-jars to be uploaded through the
blob-server.
+ */
+public final class JobSubmitRequestBody implements RequestBody {
+
+ private static final String FIELD_NAME_SERIALIZED_JOB_GRAPH =
"serializedJobGraph";
+
+ /**
+ * The serialized job graph.
+ */
+ @JsonProperty(FIELD_NAME_SERIALIZED_JOB_GRAPH)
+ public final byte[] serializedJobGraph;
+
+ public JobSubmitRequestBody(JobGraph jobGraph) throws IOException {
+ this(serializeJobGraph(jobGraph));
+ }
+
+ @JsonCreator
+ public JobSubmitRequestBody(
+ @JsonProperty(FIELD_NAME_SERIALIZED_JOB_GRAPH) byte[]
serializedJobGraph) {
+
+ this.serializedJobGraph = serializedJobGraph;
+ }
+
+ @Override
+ public int hashCode() {
+ return 71 * Arrays.hashCode(this.serializedJobGraph);
+ }
+
+ @Override
+ public boolean equals(Object object) {
+ if (object instanceof JobSubmitRequestBody) {
+ JobSubmitRequestBody other = (JobSubmitRequestBody)
object;
+ return Arrays.equals(this.serializedJobGraph,
other.serializedJobGraph);
+ }
+ return false;
+ }
+
+ private static byte[] serializeJobGraph(JobGraph jobGraph) throws
IOException {
+ ByteArrayOutputStream baos = new ByteArrayOutputStream(1024);
+ ObjectOutputStream out = new ObjectOutputStream(baos);
+
+ out.writeObject(jobGraph);
+
+ return baos.toByteArray();
--- End diff --
we could close the streams. Maybe execute in try with resources block. Sure
it is more of an idiomatic thing than a true problem here.
---
