Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4742#discussion_r141868101
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -554,6 +557,18 @@ protected int stop(String[] args) {
return handleArgException(new CliArgsException("Missing
JobID"));
}
+ // FLIP-6 specific branch
+ try {
+ CustomCommandLine<?> activeCommandLine =
getActiveCustomCommandLine(options.getCommandLine());
+ if (activeCommandLine instanceof Flip6DefaultCLI) {
+ ClusterClient client =
activeCommandLine.retrieveCluster(options.getCommandLine(), config,
configurationDirectory);
+ client.stop(jobId);
--- End diff --
Could we integrate the other stopping behaviour from the old code into the
`ClusterClient`? Then we would simply retrieve the `ClusterClient` and call
`stop` without having this special case where we exit early in case of Flip-6?
---
