[
https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188028#comment-16188028
]
ASF GitHub Bot commented on FLINK-7068:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4358#discussion_r142131457
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobKey.java ---
@@ -83,30 +113,34 @@ public boolean equals(final Object obj) {
final BlobKey bk = (BlobKey) obj;
- return Arrays.equals(this.key, bk.key);
+ return Arrays.equals(this.key, bk.key) && this.type == bk.type;
}
@Override
public int hashCode() {
- return Arrays.hashCode(this.key);
+ return Arrays.hashCode(this.key) + this.type.hashCode();
--- End diff --
I think when one combines field, then one should multiply the fields with a
prime, e.g. `37`.
> change BlobService sub-classes for permanent and transient BLOBs
> ----------------------------------------------------------------
>
> Key: FLINK-7068
> URL: https://issues.apache.org/jira/browse/FLINK-7068
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> A {{PermanentBlobStore}} should resemble use cases for BLOBs that are
> permanently stored for a job's life time (HA and non-HA).
> A {{TransientBlobStore}} should reflect BLOB offloading for logs, RPC, etc.
> which even does not have to be reflected by files.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
