[
https://issues.apache.org/jira/browse/FLINK-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188308#comment-16188308
]
ASF GitHub Bot commented on FLINK-7749:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4762
[FLINK-7749][network] remove the ResultPartitionWriter wrapper
## What is the purpose of the change
After changing task event notification to the `TaskEventDispatcher` (#4759)
and buffer writing to `ResultPartition` (#4761) this PR finally removes the
`ResultPartitionWriter` wrapper.
## Brief change log
- remove `ResultPartitionWriter` and adapt all classes to use
`ResultPartition` instead
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (yes)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-7749
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4762.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4762
----
commit d0cf483e0fb21010ed996935ffb14d62b34ee8ed
Author: Nico Kruber <[email protected]>
Date: 2017-08-29T15:32:52Z
[FLINK-7746][network] move ResultPartitionWriter#writeBufferToAllChannels
implementation up into ResultPartition
commit cfea094aa214612eaafef14554bc68626a6ff948
Author: Nico Kruber <[email protected]>
Date: 2017-08-29T16:24:00Z
[FLINK-7748][network] properly use the TaskEventDispatcher for subscribing
to events
Previously, the ResultPartitionWriter implemented the EventListener
interface
and was used for event registration, although event publishing was already
handled via the TaskEventDispatcher. Now, we use the TaskEventDispatcher for
both, event registration and publishing.
It also adds the TaskEventDispatcher to the Environment information for a
task
to be able to work with it (only IterationHeadTask so far).
commit 88a0d0efc3e4daabbb6ac50ca0d5fa0481a333b6
Author: Nico Kruber <[email protected]>
Date: 2017-08-29T16:53:48Z
[FLINK-7749][network] remove the ResultPartitionWriter wrapper
Previous tasks, i.e. task event notification and buffer writing, are now
handled
completely by the TaskEventDispatcher and the ResultPartition, respectively.
----
> remove the ResultPartitionWriter
> --------------------------------
>
> Key: FLINK-7749
> URL: https://issues.apache.org/jira/browse/FLINK-7749
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> After changing task event notification to the {{TaskEventDispatcher}}
> (FLINK-7746) and buffer writing to {{ResultPartition}} (FLINK-7748), we can
> finally remove the {{ResultPartitionWriter}} wrapper.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
