Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4742#discussion_r142507812
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -554,6 +557,18 @@ protected int stop(String[] args) {
return handleArgException(new CliArgsException("Missing
JobID"));
}
+ // FLIP-6 specific branch
+ try {
+ CustomCommandLine<?> activeCommandLine =
getActiveCustomCommandLine(options.getCommandLine());
+ if (activeCommandLine instanceof Flip6DefaultCLI) {
+ ClusterClient client =
activeCommandLine.retrieveCluster(options.getCommandLine(), config,
configurationDirectory);
+ client.stop(jobId);
--- End diff --
The existing client doesn't use the ClusterClient to issue stop/cancel but
goes directly through the actor system. While the ClusterClient DOES have a
stop/cancel method, it is actually never called (god knows why...).
---
