[ 
https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190254#comment-16190254
 ] 

ASF GitHub Bot commented on FLINK-7072:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4742#discussion_r142507812
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
    @@ -554,6 +557,18 @@ protected int stop(String[] args) {
                        return handleArgException(new CliArgsException("Missing 
JobID"));
                }
     
    +           // FLIP-6 specific branch
    +           try {
    +                   CustomCommandLine<?> activeCommandLine = 
getActiveCustomCommandLine(options.getCommandLine());
    +                   if (activeCommandLine instanceof  Flip6DefaultCLI) {
    +                           ClusterClient client = 
activeCommandLine.retrieveCluster(options.getCommandLine(), config, 
configurationDirectory);
    +                           client.stop(jobId);
    --- End diff --
    
    The existing client doesn't use the ClusterClient to issue stop/cancel but 
goes directly through the actor system. While the ClusterClient DOES have a 
stop/cancel method, it is actually never called (god knows why...).


> Create RESTful cluster endpoint
> -------------------------------
>
>                 Key: FLINK-7072
>                 URL: https://issues.apache.org/jira/browse/FLINK-7072
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Till Rohrmann
>            Assignee: Chesnay Schepler
>              Labels: flip-6
>             Fix For: 1.4.0
>
>
> In order to communicate with the cluster from the RESTful client, we have to 
> implement a RESTful cluster endpoint. The endpoint shall support the 
> following operations:
> * List jobs (GET): Get list of all running jobs on the cluster
> * Submit job (POST): Submit a job to the cluster (only supported in session 
> mode)
> * Get job status (GET): Get the status of an executed job (and maybe the 
> JobExecutionResult)
> * Lookup job leader (GET): Gets the JM leader for the given job
> This endpoint will run in session mode alongside the dispatcher/session 
> runner and forward calls to this component which maintains a view on all 
> currently executed jobs.
> In the per-job mode, the endpoint will return only the single running job and 
> the address of the JobManager alongside which it is running. Furthermore, it 
> won't accept job submissions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to