[
https://issues.apache.org/jira/browse/FLINK-7753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190591#comment-16190591
]
ASF GitHub Bot commented on FLINK-7753:
---------------------------------------
GitHub user EronWright opened a pull request:
https://github.com/apache/flink/pull/4765
[FLINK-7753] [flip-6] close REST channel on server error
## What is the purpose of the change
Improve REST server handling of unexpected errors.
## Brief change log
- Close the connection when returning a 500 response.
- Obey rfc2616#section-14.10 which says that HTTP 1.1 responses should
explicitly say `Connection: close` if keep-alive was requested but not agreed
to.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
## Documentation
- Does this pull request introduce a new feature? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/EronWright/flink FLINK-7753
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4765.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4765
----
commit 1f9fef31323750cbaa8bd17fa7df93c7eb14a09f
Author: Wright, Eron <[email protected]>
Date: 2017-09-29T18:08:25Z
[FLINK-7753] [flip-6] close REST channel on server error, obey
rfc2616#section-14.10
----
> HandlerUtils should close the channel on error responses
> --------------------------------------------------------
>
> Key: FLINK-7753
> URL: https://issues.apache.org/jira/browse/FLINK-7753
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management, Mesos
> Reporter: Eron Wright
> Assignee: Eron Wright
> Priority: Minor
>
> Unexpected errors in the server pipeline correctly cause a 500 error
> response. I suggest that such responses also close the channel rather than
> allowing keep-alive. This would be a better security posture too since we
> don't know if the pipeline is corrupt following an unexpected error.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
