Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4742#discussion_r142625774
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/deployment/Flip6StandaloneClusterDescriptor.java
---
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.client.deployment;
+
+import org.apache.flink.client.program.rest.RestClusterClient;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.JobManagerOptions;
+import org.apache.flink.runtime.jobgraph.JobGraph;
+
+/**
+ * A deployment descriptor for an existing cluster.
+ */
+public class Flip6StandaloneClusterDescriptor implements
ClusterDescriptor<RestClusterClient> {
+
+ private final Configuration config;
+
+ public Flip6StandaloneClusterDescriptor(Configuration config) {
+ this.config = config;
+ }
+
+ @Override
+ public String getClusterDescription() {
+ String host = config.getString(JobManagerOptions.ADDRESS, "");
+ int port = config.getInteger(JobManagerOptions.PORT, -1);
+ return "FLIP-6 Standalone cluster at " + host + ":" + port;
+ }
+
+ @Override
+ public RestClusterClient retrieve(String applicationID) {
+ try {
+ return new RestClusterClient(config);
+ } catch (Exception e) {
+ throw new RuntimeException("Couldn't retrieve
standalone cluster", e);
--- End diff --
I'd keep it like this to be consistent with all other implementations. I do
think the signature should have a proper checked exception, but I wouldn't do
it in this PR tbh.
---
