[
https://issues.apache.org/jira/browse/FLINK-7709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191304#comment-16191304
]
ASF GitHub Bot commented on FLINK-7709:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4763
Reviewed 24 of 31 files at r1.
Review status: 21 of 26 files reviewed at latest revision, 2 unresolved
discussions, some commit checks failed.
---
*[flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/checkpoints/CheckpointStatsCache.java,
line 44 at
r1](https://reviewable.io:443/reviews/apache/flink/4763#-KvbgxjlkW5IZW5m8HYM:-KvbgxjlkW5IZW5m8HYN:bwa0bd4)
([raw
file](https://github.com/apache/flink/blob/d152cf222422fd1565f4ea60fd6e8b62604a1dd1/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/checkpoints/CheckpointStatsCache.java#L44)):*
> ```Java
> private final Cache<Long, AbstractCheckpointStats> cache;
>
> public CheckpointStatsCache(int maxNumEntries) {
> ```
The CheckpointStatsCache should be moved out of the legacy namespace.
---
*[flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java,
line 233 at
r1](https://reviewable.io:443/reviews/apache/flink/4763#-Kvbj3-UxgqUuhmsfJcA:-Kvbj3-VGSGSiPo7duwE:b-ryryhy)
([raw
file](https://github.com/apache/flink/blob/d152cf222422fd1565f4ea60fd6e8b62604a1dd1/flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/checkpoints/CheckpointStatistics.java#L233)):*
> ```Java
> }
> } else {
> checkpointStatisticsPerTask =
Collections.emptyMap();
> ```
This method is near identical to `CheckpointingStatistics#generate...`,
except this one line.
---
*Comments from
[Reviewable](https://reviewable.io:443/reviews/apache/flink/4763)*
<!-- Sent from Reviewable.io -->
> Port CheckpointStatsDetailsHandler to new REST endpoint
> -------------------------------------------------------
>
> Key: FLINK-7709
> URL: https://issues.apache.org/jira/browse/FLINK-7709
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, REST, Webfrontend
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.4.0
>
>
> Port existing {{CheckpointStatsDetailsHandler}} to new REST endpoint.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
