GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/4774
[FLINK-6495] Fix Akka's default value for heartbeat pause
## Brief change log
This PR consists of two hotfixes regarding akka's heartbeat pause. The
critical one is reverting it's default value from 10s back to 60s (bug
introduced by #3935)
## Verifying this change
This change is already covered by existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (**yes (default config values)** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pnowojski/flink akka
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4774.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4774
----
commit 0f17a2998d343bc78bb01533a6fcf847d657c38c
Author: Piotr Nowojski <[email protected]>
Date: 2017-10-02T17:33:46Z
[hotfix][config] Revert heartbeat pause back to 60s
This fixes an important bug introduced by FLINK-6495. Heartbeat pause MUST
be
significantly larger then heartbeat interval.
commit 07fd359be00c8de6c1473c6c5631b4bdeee0c586
Author: Piotr Nowojski <[email protected]>
Date: 2017-10-04T11:26:16Z
[hotfix][runtime] Fix default value for restart delay
1. Previously default value didn't match with an exception message being
thrown.
2. HEARTBEAT_PAUSE is more sane default value for the delay, becauce we
want to
wait long enough before restart, for actors to realize about previous crash.
----
---
