[
https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192711#comment-16192711
]
ASF GitHub Bot commented on FLINK-7491:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4585#discussion_r142903359
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1412,23 +1412,12 @@ object AggregateUtil {
case collect: SqlAggFunction if collect.getKind == SqlKind.COLLECT
=>
aggregates(index) = sqlTypeName match {
- case TINYINT =>
- new ByteCollectAggFunction
- case SMALLINT =>
- new ShortCollectAggFunction
- case INTEGER =>
- new IntCollectAggFunction
- case BIGINT =>
- new LongCollectAggFunction
- case VARCHAR | CHAR =>
- new StringCollectAggFunction
- case FLOAT =>
- new FloatCollectAggFunction
- case DOUBLE =>
- new DoubleCollectAggFunction
+ case TINYINT | SMALLINT | INTEGER | BIGINT | VARCHAR | CHAR |
FLOAT | DOUBLE =>
--- End diff --
I was rather thinking to remove the `match case` block completely and set
```
aggregates(index) = new
CollectAggFunction(FlinkTypeFactory.toTypeInfo(relDataType))
```
> Support COLLECT Aggregate function in Flink SQL
> -----------------------------------------------
>
> Key: FLINK-7491
> URL: https://issues.apache.org/jira/browse/FLINK-7491
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Shuyi Chen
> Assignee: Shuyi Chen
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
