Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r142903359 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1412,23 +1412,12 @@ object AggregateUtil { case collect: SqlAggFunction if collect.getKind == SqlKind.COLLECT => aggregates(index) = sqlTypeName match { - case TINYINT => - new ByteCollectAggFunction - case SMALLINT => - new ShortCollectAggFunction - case INTEGER => - new IntCollectAggFunction - case BIGINT => - new LongCollectAggFunction - case VARCHAR | CHAR => - new StringCollectAggFunction - case FLOAT => - new FloatCollectAggFunction - case DOUBLE => - new DoubleCollectAggFunction + case TINYINT | SMALLINT | INTEGER | BIGINT | VARCHAR | CHAR | FLOAT | DOUBLE => --- End diff -- I was rather thinking to remove the `match case` block completely and set ``` aggregates(index) = new CollectAggFunction(FlinkTypeFactory.toTypeInfo(relDataType)) ```
---