[
https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192743#comment-16192743
]
ASF GitHub Bot commented on FLINK-7072:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4742#discussion_r142897184
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java
---
@@ -610,25 +633,15 @@ public void cancel(JobID jobId) throws Exception {
* failed. That might be due to an I/O problem, ie, the
job-manager is unreachable.
*/
public void stop(final JobID jobId) throws Exception {
- final ActorGateway jobManagerGateway = getJobManagerGateway();
+ final ActorGateway jobManager = getJobManagerGateway();
- final Future<Object> response;
- try {
- response = jobManagerGateway.ask(new
JobManagerMessages.StopJob(jobId), timeout);
- } catch (final Exception e) {
- throw new ProgramInvocationException("Failed to query
the job manager gateway.", e);
- }
+ Future<Object> response = jobManager.ask(new
JobManagerMessages.StopJob(jobId), timeout);
- final Object result = Await.result(response, timeout);
+ final Object rc = Await.result(response, timeout);
- if (result instanceof JobManagerMessages.StoppingSuccess) {
- log.info("Job stopping with ID " + jobId + "
succeeded.");
- } else if (result instanceof
JobManagerMessages.StoppingFailure) {
- final Throwable t =
((JobManagerMessages.StoppingFailure) result).cause();
- log.info("Job stopping with ID " + jobId + " failed.",
t);
- throw new Exception("Failed to stop the job because of
\n" + t.getMessage());
- } else {
- throw new Exception("Unknown message received while
stopping: " + result.getClass().getName());
+ if (rc instanceof JobManagerMessages.StoppingFailure) {
+ throw new Exception("Stopping the job with ID " + jobId
+ " failed.",
+ ((JobManagerMessages.StoppingFailure)
rc).cause());
--- End diff --
The unknown response type exception was lost
> Create RESTful cluster endpoint
> -------------------------------
>
> Key: FLINK-7072
> URL: https://issues.apache.org/jira/browse/FLINK-7072
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Till Rohrmann
> Assignee: Chesnay Schepler
> Labels: flip-6
> Fix For: 1.4.0
>
>
> In order to communicate with the cluster from the RESTful client, we have to
> implement a RESTful cluster endpoint. The endpoint shall support the
> following operations:
> * List jobs (GET): Get list of all running jobs on the cluster
> * Submit job (POST): Submit a job to the cluster (only supported in session
> mode)
> * Get job status (GET): Get the status of an executed job (and maybe the
> JobExecutionResult)
> * Lookup job leader (GET): Gets the JM leader for the given job
> This endpoint will run in session mode alongside the dispatcher/session
> runner and forward calls to this component which maintains a view on all
> currently executed jobs.
> In the per-job mode, the endpoint will return only the single running job and
> the address of the JobManager alongside which it is running. Furthermore, it
> won't accept job submissions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
