Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4725#discussion_r142919779
  
    --- Diff: 
flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormatTest.java
 ---
    @@ -233,6 +255,30 @@ public void testFlush() throws SQLException, 
IOException {
                }
        }
     
    +   @Test
    +   public void testMetricsSetup() throws IOException {
    --- End diff --
    
    Can you extend this test to check that the metrics are correctly set 
(except for the `durationMs` histogram)?


---

Reply via email to