Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4742#discussion_r142930472
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobTerminationMessageParameters.java
---
@@ -28,8 +28,8 @@
*/
public class JobTerminationMessageParameters extends MessageParameters {
- private final JobIDPathParameter jobPathParameter = new
JobIDPathParameter();
- private final TerminationModeQueryParameter
terminationModeQueryParameter = new TerminationModeQueryParameter();
+ public final JobIDPathParameter jobPathParameter = new
JobIDPathParameter();
+ public final TerminationModeQueryParameter
terminationModeQueryParameter = new TerminationModeQueryParameter();
--- End diff --
well they aren't really internal fields, at least i didn't intend them to
be. The client has to resolve the parameters somehow, so we either have to add
a custom resolve method to every `MessageParameters` class (which will make for
an odd API when creating sub-classes), or provide access to each parameter
(either directly or through a getter). I opted for the direct approach since it
makes it obvious that we are in fact modifying the `MessageParameters` object.
---
