Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4624#discussion_r142933578
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCorrelate.scala
---
@@ -183,17 +183,25 @@ trait CommonCorrelate {
}
private[flink] def correlateOpName(
+ inputType: RelDataType,
rexCall: RexCall,
sqlFunction: TableSqlFunction,
- rowType: RelDataType)
+ rowType: RelDataType,
+ expression: (RexNode, List[String], Option[List[RexNode]]) => String)
: String = {
- s"correlate: ${correlateToString(rexCall, sqlFunction)}, select:
${selectToString(rowType)}"
+ s"correlate: ${correlateToString(inputType, rexCall, sqlFunction,
expression)}," +
+ s" select: ${selectToString(rowType)}"
}
- private[flink] def correlateToString(rexCall: RexCall, sqlFunction:
TableSqlFunction): String = {
- val udtfName = sqlFunction.getName
- val operands =
rexCall.getOperands.asScala.map(_.toString).mkString(",")
+ private[flink] def correlateToString(
+ inputType: RelDataType,
+ rexCall: RexCall,
+ sqlFunction: TableSqlFunction,
+ expression: (RexNode, List[String], Option[List[RexNode]]) =>
String): String = {
+ val inFields = inputType.getFieldNames.asScala.toList
+ val udtfName = sqlFunction.toString
+ val operands = rexCall.getOperands.asScala.map(expression(_, inFields,
None)).mkString(",")
--- End diff --
please add a space: `mkString(",")` -> `mkString(", ")`
---
