[
https://issues.apache.org/jira/browse/FLINK-7770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194328#comment-16194328
]
ASF GitHub Bot commented on FLINK-7770:
---------------------------------------
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/4778
[FLINK-7770][FLINK-7769][Queryable State] Refactor the Queryable State
Client.
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best possible way, please go through the checklist below,
which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a
hassle. In order to uphold a high standard of quality for code contributions,
while at the same time managing a large number of contributions, we need
contributors to prepare the contributions well, and give reviewers enough
contextual information for the review. Please also understand that
contributions that do not follow this guide will take longer to review and thus
typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are
made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of
the pull request", where *FLINK-XXXX* should be replaced by the actual issue
number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes. You can set up Travis CI to do that following [this
guide](http://flink.apache.org/contribute-code.html#best-practices).
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
(including the JIRA id)
- Once all items of the checklist are addressed, remove the above text
and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
## What is the purpose of the change
1) Refactors the Queryable State feature by moving the
`QueyableStateClient` and the `KvStateServer` code outside the runtime and into
a separate module, and
2) Changes the architecture by hiding the queryable state behind a proxy.
## Brief change log
The
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a
persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
This change added tests and can be verified as follows:
- Existing tests are ported to the new architecture.
## Does this pull request potentially affect one of the following parts:
- It affects deployment:
1. to have queryable state enabled, one has to put the queryable
state jar in Flink's lib folder
2. there is a queryable state proxy running on each TM.
## Documentation
- Does this pull request introduce a new feature? (changes existing
feature)
- If yes, how is the feature documented? (not documented yet)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink qs-client-commit-ref
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4778.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4778
----
commit fa29774f3ccc3a48c4b0c476738608371096ddbf
Author: kkloudas <[email protected]>
Date: 2017-10-04T17:11:09Z
[FLINK-7769][QS] Move queryable state outside the runtime.
Creates a separate for the queryable state and moves the client
code outside the runtime. The Task Manager is now instantiating
the KvStateServer using reflection.
commit 036f4227448cdfd99b92e5efa9b8d72120ccd7ca
Author: kkloudas <[email protected]>
Date: 2017-10-05T13:16:23Z
[FLINK-7770][QS] Hide the queryable state behind a proxy.
Previously the QueryableStateClient could connect to the JM
and the TMs directly to fetch the required state. Now, there
is a proxy running on each TM and the remote client connects
to one of these proxies in order to get its state. The proxy
receives the request from the client, performs all necessary
message exchanges within the Flink cluster, receives the state
and forwards it back to the client.
This architecture allows for more security features to be
integrated in the future, as the proxy is running in the
cluster, it exposes less information about the cluster to
the outside world, and is more suitable for containerized
environments.
----
> Hide Queryable State behind a proxy.
> ------------------------------------
>
> Key: FLINK-7770
> URL: https://issues.apache.org/jira/browse/FLINK-7770
> Project: Flink
> Issue Type: Improvement
> Components: Queryable State
> Affects Versions: 1.4.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
