Github user haohui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4784#discussion_r143363766
  
    --- Diff: 
flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/GroupReduceNode.java
 ---
    @@ -97,7 +97,7 @@ else if 
(Optimizer.HINT_LOCAL_STRATEGY_COMBINING_SORT.equals(localStrategy)) {
                
                // check if we can work with a grouping (simple reducer), or if 
we need ordering because of a group order
                Ordering groupOrder = null;
    -           if (getOperator() instanceof GroupReduceOperatorBase) {
    +           if (getOperator() != null) {
    --- End diff --
    
    doesn't seems to be equivalent?


---

Reply via email to