Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4764#discussion_r143685204
  
    --- Diff: 
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
 ---
    @@ -618,19 +600,8 @@ public void releaseSnapshotResources() {
                                IOUtils.closeQuietly(readOptions);
                                readOptions = null;
                        }
    -           }
     
    -           /**
    -            * Drop the created snapshot if we have ben cancelled.
    -            */
    -           public void dropSnapshotResult() {
    -                   if (null != snapshotResultStateHandle) {
    -                           try {
    -                                   
snapshotResultStateHandle.discardState();
    --- End diff --
    
    Cleanup is now handled somewhere else?


---

Reply via email to