[
https://issues.apache.org/jira/browse/FLINK-7780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198557#comment-16198557
]
ASF GitHub Bot commented on FLINK-7780:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4789
[FLINK-7780] [REST][Client] Define protocol for triggering savepoints
Based on #4788.
## What is the purpose of the change
This PR includes all the client-side changes necessary to trigger
savepoints with FLIP-6, including the message headers etc. . It does NOT
include a port of the savepoint handlers.
Do note that the REST protocol is _incompatible_ with the existing
savepoint handlers. For one it is now a POST instead of GET (as it should be),
and the savepoint target directory is no longer a path but a query parameter
(for the reasoning, see SavepointTriggerHeaders#getTargetRestEndpointURL).
There has also been a recent discussion on the mailing list to make this a
query parameter.
## Brief change log
* refactor/add utility classes for easier testing
* move savepoint logic from CliFrontend into ClusterClient (as we did with
stop/cancel in ad380463d3d44cdd98302bf072bc5deba8696b5b)
* define REST protocol for triggering savepoints and integrate it into the
`RestClusterClient`
## Verifying this change
This change added tests and can be verified as follows:
* the changes to the CliFrontend are covered by modified tests in
CliFrontendSavepointTest
* the changes to the ClusterClient are covered by new tests in
ClusterClientTest
* the changes to the RestClusterClient are covered by
RestClusterClientTest#testTriggerSavepoint
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7780
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4789.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4789
----
commit 237140e0799bf20869fcb2bc168e05e879d23895
Author: zentol <[email protected]>
Date: 2017-10-10T10:57:05Z
[FLINK-7790] [REST] Unresolved query params not added to request URL
commit 03418468b7eba607d3df31870da6651da479455b
Author: zentol <[email protected]>
Date: 2017-10-09T11:06:06Z
[refactor] [tests] Refactor CliFrontend mocking into utility class
commit 88010f49dcf452186d56cf9575835a3d738ddff5
Author: zentol <[email protected]>
Date: 2017-10-10T11:22:59Z
[refactor] [tests] Generalize gateway mocking in ClusterClientTest
commit 9949452a5c656266008dec8718e32db11c05fbe3
Author: zentol <[email protected]>
Date: 2017-10-10T11:23:21Z
[refactor] [tests] Generalize test handler generation
commit ffcd614f4c5b55f84cbe8f2c591c138ea21d588b
Author: zentol <[email protected]>
Date: 2017-10-09T11:34:52Z
[FLINK-7780] [Client] Move savepoint logic into ClusterClient
commit ed5e241e38bc0af8bdde49483dc6a673f09fd0a3
Author: zentol <[email protected]>
Date: 2017-10-09T16:09:36Z
[FLINK-7780] [REST] Define savepoint trigger protocol
----
> Integrate savepoint command into REST client
> --------------------------------------------
>
> Key: FLINK-7780
> URL: https://issues.apache.org/jira/browse/FLINK-7780
> Project: Flink
> Issue Type: Sub-task
> Components: Client, REST
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
