Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4729#discussion_r143959669
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile
resourceProfile) {
}
@Override
- public void stopWorker(ResourceID resourceID) {
- // TODO: Implement to stop the worker
+ public void stopWorker(YarnWorkerNode workerNode) {
+ workerNodeMap.remove(workerNode.getResourceID().toString());
--- End diff --
I might have already asked you this, but looking at the code, I think we
initialize the `ResourceID` on the `TaskManager` with `ContainerId.toString`.
Can't we use this to reconstruct the `ContainerId` similar to
http://hadoop.apache.org/docs/r2.8.0/api/org/apache/hadoop/yarn/api/records/ContainerId.html#fromString(java.lang.String)?
---
