[
https://issues.apache.org/jira/browse/FLINK-7818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201119#comment-16201119
]
ASF GitHub Bot commented on FLINK-7818:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4811
[FLINK-7818] Synchronize MetricStore access in TaskManagersHandler
## What is the purpose of the change
Synchronize MetricStore access in TaskManagersHandler
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixTaskManagersHandler
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4811.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4811
----
commit 4291b5aa1b3687ee7ba11876ca35f91e33ad3360
Author: Till Rohrmann <[email protected]>
Date: 2017-10-11T17:00:16Z
[FLINK-7818] Synchronize MetricStore access in TaskManagersHandler
----
> Synchronize MetricStore access in the TaskManagersHandler
> ---------------------------------------------------------
>
> Key: FLINK-7818
> URL: https://issues.apache.org/jira/browse/FLINK-7818
> Project: Flink
> Issue Type: Bug
> Components: Metrics, REST
> Affects Versions: 1.4.0, 1.3.2
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> The {{TaskManagersHandler}} accesses the {{MetricStore}} when details for a
> single {{TaskManager}} are requested. The access is not synchronized which
> can be problematic because the {{MetricStore}} is not thread safe.
> I propose to add synchronization.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
