[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201566#comment-16201566
]
ASF GitHub Bot commented on FLINK-7416:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r144214324
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -272,4 +316,53 @@ private void decodeBufferOrEvent(RemoteInputChannel
inputChannel, NettyMessage.B
bufferOrEvent.releaseBuffer();
}
}
+
+ private void writeAndFlushNextMessageIfPossible(Channel channel) {
+ if (channelError.get() != null) {
+ return;
+ }
+
+ if (channel.isWritable()) {
--- End diff --
Sorry, I could be more clear :) I meant that shorter of the if/else branch
should go first for readability. Here instead of:
```
if (channel.isWritable()) {
// long
// block
{
// of
{
// nested
// code
}
}
}
```
you could have:
```
if (!channel.isWritable()) {
return;
}
// long
// block
{
// of
{
// nested
// code
}
}
}
```
which is easier to understand because reader immediately knows that one of
the branch is super simple and code doesn't nest that deeply.
> Implement Netty receiver outgoing pipeline for credit-based
> -----------------------------------------------------------
>
> Key: FLINK-7416
> URL: https://issues.apache.org/jira/browse/FLINK-7416
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.4.0
>
>
> This is a part of work for credit-based network flow control.
> The related works are :
> * We define a new message called {{AddCredit}} to notify the incremental
> credit during data shuffle.
> * Whenever an {{InputChannel}}’s unannounced credit goes up from zero, the
> channel is enqueued in the pipeline.
> * Whenever the channel becomes writable, it takes the next {{InputChannel}}
> and sends its unannounced credit. The credit is reset to zero after each sent.
> * That way, messages are sent as often as the network has capacity and
> contain as much credit as available for the channel at that point in time.
> Otherwise, it would only add latency to the announcements and not increase
> throughput.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
